Skip to content

deew - #64149

Closed
Anca Cismasiu (ancasnyk) wants to merge 1 commit into
microsoft:mainfrom
ancasnyk:pr_check
Closed

deew#64149
Anca Cismasiu (ancasnyk) wants to merge 1 commit into
microsoft:mainfrom
ancasnyk:pr_check

Conversation

@ancasnyk

Copy link
Copy Markdown

Fixes #

Copilot AI balanced review requested due to automatic review settings September 3, 2026 15:11
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Sep 3, 2026
@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 3, 2026
@typescript-automation

Copy link
Copy Markdown

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The exposed token must be removed and rotated, and the invalid compiler option deleted.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an npm authentication token to the VS Code extension’s TypeScript configuration.

Changes:

  • Introduces NPM_TOKEN as an invalid compiler option, exposing a credential that must be removed and rotated.
File summaries
File Review
packages/vscode-typescript/tsconfig.json Contains an exposed npm token and invalid TypeScript compiler option.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +13 to +14
"noImplicitOverride": true,
"NPM_TOKEN":"npm_t8Vb2Nq5Xz7Lm1Kc4Rw9Yd3Hf6Jp0Sg5Bu1N"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants