API: add formatDiagnostic and flattenDiagnosticMessageText - #64150
Open
Matheus Mol (oMatheusmol) wants to merge 1 commit into
Open
API: add formatDiagnostic and flattenDiagnosticMessageText#64150Matheus Mol (oMatheusmol) wants to merge 1 commit into
Matheus Mol (oMatheusmol) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Matheus Mol (oMatheusmol)
September 3, 2026 16:47
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is focused, preserves existing formatter behavior, and includes appropriate API coverage.
Pull request overview
Adds the remaining single-diagnostic formatting utilities to the synchronous and asynchronous TypeScript APIs.
Changes:
- Exports
formatDiagnosticandflattenDiagnosticMessageText. - Reuses these helpers in existing formatters.
- Adds API tests for formatting and nested message chains.
File summaries
| File | Description |
|---|---|
packages/typescript/src/api/diagnosticFormatter.ts |
Implements and integrates the new helpers. |
packages/typescript/src/api/async/api.ts |
Exports helpers from the async API. |
packages/typescript/src/api/sync/api.ts |
Exports helpers from the sync API. |
packages/typescript/test/diagnosticFormatter.test.ts |
Tests formatting, composition, and message-chain flattening. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two remaining per-diagnostic helpers from the 6.x API that were left out when
formatDiagnosticswas ported in #63935 (roadmap #63875).