[dotnet-port-api] Add per-tool agent mode controls - #1111
Quim Muntal (qmuntal) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The built-in mode_set path can clear a queued PreviousMode notification, so the moderate finding must be addressed.
Review effort: Lite
Findings: None
What changed in this PR
Adds per-tool mode_set/mode_get controls and silent session mode changes to the Go agent-mode harness, with tests and .NET parity documentation.
Changes:
- Adds independent tool-disable controls and instruction rewriting.
- Adds silent mode updates that clear pending notifications.
- Expands tests and parity documentation.
| File | Summary |
|---|---|
docs/dotnet-go-sdk-feature-comparison.md |
Documents per-tool agent-mode parity. |
agent/harness/agentmode/agentmode.go |
Implements controls and silent mode changes; the built-in mode_set path must preserve queued PreviousMode notifications. |
agent/harness/agentmode/agentmode_test.go |
Adds coverage for tool combinations, instructions, and notification behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Scope: public API, user-visible behavior Changed Go contract:
Upstream evidence reviewed:
Result: aligned. The per-tool disable flags default to
|
Tip
Your pull request is ready to create! 🎉 ✅
Everything is OK—the changes have been pushed to branch
dotnet-port-api-agentmode-tool-controls-20260918-a1a5742accaf6893. Please review the changes, including any protected files, before creating the pull request.Create the pull request
The original pull request description is below.
Summary
Align
agent/harness/agentmodewith the .NET per-toolAgentModeProvidercontrols from microsoft/agent-framework#8458. This addsDisableModeSetToolandDisableModeGetToolconfig flags, keeps the default injected instructions coherent when either built-in tool is disabled, addsSetModeForSessionSilentlyfor custom mode-switch flows that should not queue a follow-up notification, and extends the parity doc and package tests to cover the new behavior.Ported .NET PRs
dcd2c4d1e0b0fce6bcebe0f3d244351ba9002a80Breaking Changes
No.
Tests and Examples
go test ./agent/harness/agentmodego test ./agent/harness/...Notes
upstream-agent-framework/mainfetch was blocked by the firewall in this environment, so upstream inspection used the GitHub read bridge against the merged .NET PR and commit instead of a refreshed local remote-tracking ref.[dotnet-port-api]plus themode_set/mode_getAgentMode surface returned no matching workflow tracking issue before this port.Closes #1097