Skip to content

Add Aspire-shaped theme transitions and Aspiry whimsy - #1956

Draft
David Pine (IEvangelist) wants to merge 7 commits into
mainfrom
ievangelist-aspire-theme-ripple
Draft

David Pine (IEvangelist) wants to merge 7 commits into
mainfrom
ievangelist-aspire-theme-ripple

Conversation

@IEvangelist

Copy link
Copy Markdown
Member

Summary

  • reveal theme changes from the interaction point using a brief Aspire-logo-shaped transition
  • support footer and Starlight theme controls, pointer and keyboard origins, auto theme resolution, rapid cancellation, and reduced-motion fallback
  • show destination-specific sunglasses or night-vision Aspiry artwork when users quickly reverse the theme, with replacement and click-to-dismiss behavior
  • add component and end-to-end coverage for persistence, cleanup, reduced motion, reverse-toggle timing, artwork selection, replacement, and dismissal

Tests

  • pnpm --dir .\src\frontend lint
  • pnpm --dir .\src\frontend run test:unit:components (70 passed)
  • pnpm --dir .\src\frontend exec playwright test tests/e2e/ui-regressions.spec.ts --grep "footer preferences persist theme|theme changes skip decorative motion|quick reverse theme changes" (9 passed across desktop, tablet, and mobile)

pnpm build was not run locally.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 03:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved cancellation races can override the latest theme selection or remove replacement artwork, and sidebar transitions and reduced-motion cleanup need correction.

4 open issues
What changed in this PR

Adds branded theme-switching effects to aspire.dev, integrating an Aspire-shaped reveal and destination-specific Aspiry artwork with existing theme controls.

Changes:

  • Introduces a shared transition controller with interaction origins, reduced-motion fallback, and quick-reversal artwork.
  • Connects footer preferences to the controller and supplies mascot assets through the site footer.
  • Adds component rendering and end-to-end coverage for persistence, reduced motion, and artwork behavior.
File Description
src/​frontend/​tests/​unit/​custom-components.vitest.test.ts Adds rendering coverage for transition and artwork hooks.
src/​frontend/​tests/​e2e/​ui-regressions.spec.ts Tests theme persistence, cleanup, reduced motion, and mascot interactions.
src/​frontend/​src/​components/​ThemeTransition.astro Implements theme transitions, artwork, and control synchronization.
src/​frontend/​src/​components/​starlight/​Footer.astro Mounts the controller with mascot assets.
src/​frontend/​src/​components/​FooterPreferences.astro Routes theme selections and interaction origins through the controller.

Review effort: Balanced

Comment thread src/frontend/src/components/ThemeTransition.astro Outdated
Comment thread src/frontend/src/components/ThemeTransition.astro Outdated
Comment thread src/frontend/src/components/ThemeTransition.astro
Comment thread src/frontend/src/components/ThemeTransition.astro Outdated
@IEvangelist

David Pine (IEvangelist) commented Oct 27, 2026 •

Copy link
Copy Markdown
Member Author

Superseded by the updated restrained-animation demo: #1956 (comment)

@IEvangelist
David Pine (IEvangelist) enabled auto-merge (squash) October 27, 2026 03:30
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1956. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1956 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@IEvangelist

David Pine (IEvangelist) commented Oct 27, 2026 •

Copy link
Copy Markdown
Member Author

Superseded by the latest draft motion demo: #1956 (comment)

@IEvangelist
David Pine (IEvangelist) marked this pull request as draft October 27, 2026 12:44
auto-merge was automatically disabled October 27, 2026 12:44

Pull request was converted to draft

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@IEvangelist

Copy link
Copy Markdown
Member Author

Updated demo of the approved full-page theme reveal and bottom-center Aspiry quick-reversal animation:

aspire-theme-ripple-final.webm

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@IEvangelist

Copy link
Copy Markdown
Member Author

Updated demo: Aspiry now enters from non-repeating random edges and corners with varied gestures while preserving the five-second timing:

aspiry-random-entrances.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants