Skip to content

Fix Integration Data Updater apiReference filter - #1961

Open
David Pine (IEvangelist) wants to merge 1 commit into
mainfrom
fix/integration-data-api-reference-filter
Open

David Pine (IEvangelist) wants to merge 1 commit into
mainfrom
fix/integration-data-api-reference-filter

Conversation

@IEvangelist

Copy link
Copy Markdown
Member

Summary

Fixes #1960.

The Integration Data Updater has failed since #1895 because generate-package-json.ps1 reads optional apiReference metadata directly under Set-StrictMode -Version Latest. The catalog omits the property for 209 of 210 entries, so generation aborts before processing packages.

  • Check property existence before reading apiReference.
  • Keep omitted and explicit true entries; exclude explicit false.
  • Add an executable PowerShell regression test that evaluates the production predicate against omitted/false/true fixtures and the real catalog.
  • Run that regression in the Tools Tests workflow.

Failure evidence: first affected run, latest inspected failure. Related prior repairs: #1813 and #1899; stale rolling updater PR: #1737.

Validation

  • PowerShell regression test: passed; real catalog result was 209 included, 1 excluded.
  • PackageJsonGenerator.Tests: 41/41 passed.
  • AtsJsonGenerator.Tests: 37/37 passed.
  • update-integrations.vitest.test.ts: 50/50 passed.
  • PowerShell parser for update-integration-data.ps1: 0 errors.
  • actionlint .github/workflows/tools-tests.yml: passed.
  • git diff --check: passed.

Limitations

A complete updater workflow_dispatch was not run because main still contains the failing predicate; running it before this fix lands would reproduce the known failure and cannot validate the branch change. The PR's Tools Tests exercise the exact production predicate, and the next post-merge manual/scheduled updater run should provide end-to-end confirmation.

🤖 Posted by Repository agent (AI Agent)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 13:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow fix preserves the required filtering behavior, with direct regression coverage and CI integration; no blocking issues remain.

No open issues 🎉

What changed in this PR

Fixes #1960 by preventing the Integration Data Updater from reading missing apiReference metadata under PowerShell strict mode.

Changes:

  • Includes catalog entries with omitted or explicit true metadata and excludes explicit false.
  • Adds regression coverage that executes the production predicate against fixtures and the real catalog.
  • Runs the regression in the Tools Tests workflow.
File Description
tests/​PackageJsonGenerator.Tests/​generate-package-json.Tests.ps1 Tests the production filter under strict mode.
src/​tools/​PackageJsonGenerator/​generate-package-json.ps1 Checks property existence before reading optional metadata.
.github/​workflows/​tools-tests.yml Adds the PowerShell regression test to CI.

Review effort: Balanced

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1961. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1961 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

Copy link
Copy Markdown
Member Author

CI update: the change-specific checks pass, including Tools Generator Tests, frontend validation, both CodeQL analyses, AppHost build, and frontend build. The required gate is currently blocked by all six Playwright shards timing out in existing API navigation/search tests; the same desktop E2E check is also failing on open PRs #1958 and #1955, and this PR does not change frontend code. Representative failure: https://github.com/microsoft/aspire.dev/actions/runs/40508362949/job/122207506451

🤖 Posted by Repository agent (AI Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration Data Updater fails when apiReference is omitted

2 participants