[High] Patch rust for CVE-2026-82254 - #18900
Open
BinduSri-6522866 wants to merge 2 commits into
Open
BinduSri-6522866 wants to merge 2 commits into
BinduSri-6522866 wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
BinduSri-6522866
force-pushed
the
topic_rust_CVE-2026-82254/3.0
branch
from
September 25, 2026 07:04
3c5c15b to
1394979
Compare
Kavya Sree Kaitepalli (KavyaSree2610)
approved these changes
Sep 25, 2026
Kavya Sree Kaitepalli (KavyaSree2610)
left a comment
There was a problem hiding this comment.
Patch applied cleanly, Buddy build is successful, LGTM
Kavya Sree Kaitepalli (KavyaSree2610)
marked this pull request as ready for review
September 25, 2026 16:37
Kavya Sree Kaitepalli (KavyaSree2610)
requested a review
from a team
as a code owner
September 25, 2026 16:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Patch rust for CVE-2026-82254
Commits 1–6: zero deviations — same as upstream. But 5 deviations are in commit 7.
5 deviations are in commit 7:
Commit bzip2: Fix Makefile patch breaking the package build #7's only edit here is the rename i → shift, which the patch applies exactly; upstream's u64::from(*cmd) styling is untouched context from 29ad2df41, a clippy cleanup outside our 7 commits. Patch keeps the 0.44 form (*cmd as u64 & 0x7f) << shift
ObjectId::from_bytes_or_panic does not exist in vendored gix-hash 0.13.1 — using it yields error[E0599]; From<&[u8]> is the identical conversion under the older name.
Upstream's doc references Self::from_data(), which doesn't exist in 0.44.0 — it comes from 3ef391613 ("parameterize data"), a feature commit correctly excluded from a CVE backport. Patch uses upstream's own alternative wording from the same commit, which accurately describes our at() and keeps intra-doc links resolvable.
File is not generic in 0.44.0 (generic File and the public from_data() wrapper also come from the un-backported 3ef391613), so Filecrate::MMap and data: T cannot compile here. Patch uses concrete impl File / data: Mmap with the helper kept private and doc links retargeted to File::at(); the alloc_limit_bytes cap is present and identical to upstream.
Additinally test/ folder is not present, so test changes are not applied.