Skip to content

test: add metadata for multi sku performance tests - #18904

Open
bhagyapathak wants to merge 1 commit into
4.0from
bhagya/multi-sku-metadata
Open

bhagyapathak wants to merge 1 commit into
4.0from
bhagya/multi-sku-metadata

Conversation

@bhagyapathak

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings September 18, 2026 17:25
@bhagyapathak
bhagyapathak requested a review from a team as a code owner September 18, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pinned azldev schema rejects the new sku-groups and sku-group configuration keys.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds multi-SKU performance test metadata for marketplace images.

Changes:

  • Defines a reusable Azure VM SKU group.
  • Adds five multi-SKU LISA performance tests and associates them with the marketplace image.
File summaries
File Description
base/images/images.toml Associates multi-SKU tests with the marketplace image.
base/images/images.tests.toml Defines SKU metadata and performance test groups.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread base/images/images.tests.toml Outdated
# required-capabilities : capability tokens the image must declare
#
# ============================================================================
[sku-groups.multi-sku-default]
Comment thread base/images/images.toml Outdated
{ name = "static-image-checks" },
{ group = "vm-base-functional" },
{ group = "vm-base-performance" },
{ group = "multi-sku-tests", sku-group = "multi-sku-default" },
Copilot AI review requested due to automatic review settings September 25, 2026 11:54
@bhagyapathak
bhagyapathak force-pushed the bhagya/multi-sku-metadata branch from e76aee0 to 3cb898c Compare September 25, 2026 11:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new SKU-group configuration is unsupported by the pinned strict azldev schema and will fail config validation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3 High severity

Open (3)

Comment thread base/images/images.toml
Comment on lines +165 to +166
{ group = "multi-sku-tests", sku-group = "multi-sku-amd64" },
{ group = "multi-sku-tests", sku-group = "multi-sku-arm64" },
Copilot AI review requested due to automatic review settings September 25, 2026 18:30
@bhagyapathak
bhagyapathak force-pushed the bhagya/multi-sku-metadata branch from 3cb898c to ffc003c Compare September 25, 2026 18:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new sku-groups and sku-group fields are unsupported by the pinned azldev schema and will fail strict configuration validation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3 High severity · 1 Low severity

Open (4)

Comment thread base/images/images.tests.toml Outdated
@bhagyapathak
bhagyapathak force-pushed the bhagya/multi-sku-metadata branch from ffc003c to 86a74c5 Compare September 25, 2026 19:18
Copilot AI review requested due to automatic review settings September 25, 2026 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The pinned azldev schema rejects both the new sku-groups tables and sku-group references during strict config validation.

Review effort: Balanced
Findings: 3 High severity

Open (3)
Resolved since last review (1)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants