Skip to content

Skip Dockerfile-specific .dockerignore files without warnings - #1908

Draft
Greg Villicana (grvillic) with Copilot wants to merge 2 commits into
mainfrom
copilot/dockerfile-detector-ignore-valid-files
Draft

Greg Villicana (grvillic) with Copilot wants to merge 2 commits into
mainfrom
copilot/dockerfile-detector-ignore-valid-files

Conversation

Copilot AI commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Broad Dockerfile matching includes valid ignore files such as Dockerfile.dockerignore, causing false parser warnings.

  • Filtering: Exclude filenames ending in .dockerignore, case-insensitively, before logging or parsing. Preserve detection of Dockerfile, Dockerfile.runtime, and other supported variants.
  • Regression coverage: Check silent exclusion regardless of file contents and continued detection of genuine Dockerfiles.

New Detector Checklist

Not applicable: updates an existing detector.

  • I have gone through the docs for creating a new detector here
  • My new detector implements IDefaultOffComponentDetector
  • I have created a PR to the verification repo with components that my new detector can find
  • (If necessary) I have updated the Feature Overview table in the README

Copilot AI balanced review requested due to automatic review settings November 1, 2026 21:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: grvillic <58237075+grvillic@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 1, 2026 21:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the change excluding Dockerfile-specific .dockerignore files from parsing.

No open issues 🎉

Review effort: Balanced

Copilot AI changed the title [WIP] Fix Dockerfile detector warnings on valid Dockerfile.dockerignore files Skip Dockerfile-specific .dockerignore files without warnings Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile detector warns on valid Dockerfile.dockerignore files

3 participants