Skip to content

Remove obsolete warning disables from base_macros.h #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel Jump (DanielJump) wants to merge 3 commits into
base: master
Choose a base branch
from
+0 −12
Open

Remove obsolete warning disables from base_macros.h #1625

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3eeef7
Scope the base_macros.h warning disables to base.h
DanielJump Sep 1, 2026
bd4b70c
Clean up comments in base_macros.h
DanielJump Sep 7, 2026
640e8d4
Remove obsolete base macro warning disables
DanielJump Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions strings/base_macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,6 @@

#define WINRT_IMPL_SHIM(...) (*(abi_t<__VA_ARGS__>**)&static_cast<__VA_ARGS__ const&>(static_cast<D const&>(*this)))

#ifdef _MSC_VER
// Note: this is a workaround for a false-positive warning produced by the Visual C++ 15.9 compiler.
#pragma warning(disable : 5046)

// Note: this is a workaround for a false-positive warning produced by the Visual C++ 16.3 compiler.
#pragma warning(disable : 4268)

// C++ module warnings by /W4
#pragma warning(disable : 4499)
#pragma warning(disable : 4630)
#endif // _MSC_VER

#ifndef WINRT_EXPORT
#ifdef WINRT_IMPL_BUILD_MODULE
#define WINRT_EXPORT export extern "C++"
Expand Down