Fixes and improvements - #428
Open
Chenglong Wang (Chenglong-MS) wants to merge 38 commits into
Open
Chenglong Wang (Chenglong-MS) wants to merge 38 commits into
Chenglong Wang (Chenglong-MS) wants to merge 38 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Add orcarouter to the built-in providers so Data Formulator users can connect the OrcaRouter AI gateway from the model picker and via ORCAROUTER_* environment variables, mirroring the existing ollama/openai wiring. The client routes through LiteLLM's openai provider against the OrcaRouter base URL, preserving the orcarouter/ model namespace.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ovider feat: add OrcaRouter as a built-in model provider
Adds full Hindi translations for all 10 i18n domain files, following the translation guide's rules (chart type identifiers, encoding channel keys, and other computation-bound values stay in English). Registers hi in the locale index/i18next resources and language switcher labels, and documents AVAILABLE_LANGUAGES=en,zh,hi as opt-in in .env.template. Relates to #337.
folderPathPlaceholder illustrates filesystem path syntax; translating the segment words broke the example and was inconsistent with how every other path/URL placeholder in the app is left untranslated.
Add Hindi (hi) locale for frontend i18n
Comment on lines
+823
to
+826
| '<!doctype html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width">' | ||
| '<title>OpenRouter</title></head><body><p>' + message + '</p>' | ||
| '<a href="/">Return to Data Formulator</a>' | ||
| f'<script nonce="{nonce}">{script}</script></body></html>', |
| creator_id = key_info.get("creator_user_id") | ||
| connection = { | ||
| "creator_user_id": creator_id if isinstance(creator_id, str) else None, | ||
| "settings_url": "https://openrouter.ai/keys/" + hashlib.sha256(config["api_key"].encode()).hexdigest(), |
The wrapper embeds user-supplied code, so on a system whose preferred encoding is not UTF-8 (cp1252 on Windows) writing it raised UnicodeEncodeError for any non-ASCII character, and silently transcoded the rest -- the container reads run.py as UTF-8 either way. Matches the explicit encoding already used elsewhere in the package, e.g. reasoning_log.py and analyst/skills/__init__.py.
The constant table listed DEFAULT_ROW_LIMIT_EPHEMERAL in dfSlice.tsx. That identifier does not exist anywhere in the repository, and there is no separate ephemeral row limit in the frontend.
…hemeral-row docs(dev-guides): drop the nonexistent DEFAULT_ROW_LIMIT_EPHEMERAL row
fix(sandbox): write the docker wrapper script as utf-8
Two problems stopped the SQL Server connector from working. Concurrent queries failed. The loader keeps one connection and builds a new cursor for each query. mssql-python does not support MARS, so the connection accepts only one active statement. Flask serves preview requests on parallel threads, so the requests overlapped and failed with "Connection is busy with results for another command". An RLock around _read_sql, the only place that makes a cursor, makes the requests take turns. This follows clickhouse_data_loader and mysql_data_loader. Blank connection parameters did not get their defaults. The loader read them with params.get(name, default). A saved connector spec holds an empty string, not a missing key, so the default did not apply. An empty port produced "SERVER=host,;" and the driver refused it with error 87. The loader now reads these parameters with `or`.
…-blank-port fix(mssql): serialize queries and default blank connection params
| def _write_discovery(path: Path, state: dict[str, Any]) -> None: | ||
| temporary = path.with_suffix(f".{uuid4().hex}.tmp") | ||
| try: | ||
| temporary.write_text(json.dumps(state), encoding="utf-8") |
| temporary = path.with_suffix(f".{uuid4().hex}.tmp") | ||
| try: | ||
| temporary.write_text(json.dumps(state), encoding="utf-8") | ||
| os.replace(temporary, path) |
| temporary = path.with_suffix(f".{uuid4().hex}.tmp") | ||
| try: | ||
| temporary.write_text(json.dumps(state), encoding="utf-8") | ||
| os.replace(temporary, path) |
| temporary.write_text(json.dumps(state), encoding="utf-8") | ||
| os.replace(temporary, path) | ||
| finally: | ||
| temporary.unlink(missing_ok=True) |
| actor, saved['revision'], ','.join(changed_sections)) | ||
| return json_ok(snapshot()) | ||
| except ConfigurationConflict as exc: | ||
| return {'status': 'error', 'error': {'code': 'INVALID_REQUEST', 'message': str(exc), 'retry': False}}, 409 |
|
|
||
| @staticmethod | ||
| def validate_name(name: str) -> None: | ||
| if not isinstance(name, str) or not re.fullmatch(r"[A-Za-z0-9][A-Za-z0-9_-]*(?:\.workflow)?\.ya?ml", name): |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refinements to the Data Formulator agent and context handling, focusing on clearer terminology, enhanced connector and skill management, and dependency updates. The most important changes are summarized below.
Agent and Context Terminology Improvements:
Connector Availability and Summary Enhancements:
Skill Preloading and System Prompt Improvements:
Dependency Updates:
vite,dompurify,echarts,js-yaml, and new resolutions forpostcss,esbuild, andtmp. [1] [2] [3]Documentation Cleanup:
docs/desktop-portable.mdfile has been removed.loops/model-evaluation/plan.mdhas been deleted.