Repository navigation
Fix Azure Blob payload externalization for continue-as-new carryover - #828
Merged
Merged
Conversation
Traverse completion carryover history through the shared bounded payload externalization path. Cover UTF-8 limits, protobuf hydration, concurrency, cancellation, and payload failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the carryover payload externalization change.
No open issues 🎉
What changed in this PR
Fixes #819 by including native continue-as-new carryover payloads in Azure Blob externalization, reusing the SDK’s existing size checks and bounded upload handling.
Changes:
- Processes completion carryover events through the existing history-event payload mapping.
- Adds 40 regression cases covering payload mappings, UTF-8 size boundaries, round-trip hydration, concurrency, cancellation, and failure handling.
- Adds an unreleased changelog entry; related #816 changes remain out of scope.
| File | Description |
|---|---|
test/Grpc.IntegrationTests/AzureBlobPayloadsSideCarInterceptorTests.cs |
Adds carryover externalization and hydration regression coverage. |
src/Extensions/AzureBlobPayloads/Interceptors/AzureBlobPayloadsSideCarInterceptor.cs |
Includes carryover history events in the bounded externalization runner. |
CHANGELOG.md |
Documents the carryover payload fix. |
Review effort: Balanced
kaibocai (kaibocai)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
CompleteOrchestrationAction.CarryoverEventsthrough the existing history-event payload mapping and bounded upload runner.MaxPayloadByteschecks to native carryover payloads without changing event identity, order, names, or completion metadata.CHANGELOG.md.Why is this change needed?
Issues / work items
Project checklist
release_notes.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
CHANGELOG.md.AI verification (required if AI was used):
Human attestations and the backport decision are left for review.
Testing
Automated tests
The focused reproduction was also run before the production fix:
The full solution and live Azure/DTS tests were not run.
Manual validation (only if runtime/behavior changed)
CarryoverEventseach contain exactly 1 MiB of serialized event input. Their original protobuf response exceeds 4 MiB; externalization uploads all five and reduces it below 4 MiB. Parsing the response from protobuf bytes and hydrating its events through the incoming worker-work-item path restores the complete original response, including event IDs, timestamps, order, names, completion token, version, tags, and continued-as-new status.Notes for reviewers
CHANGELOG.md; this repository does not have the template'srelease_notes.md.