Repository navigation
Fix Azure Functions E2E log framing and host isolation - #332
Open
andystaples wants to merge 3 commits into
Open
andystaples wants to merge 3 commits into
andystaples wants to merge 3 commits into
Conversation
Split concatenated timestamped records before returning matched host output, preserving strict logging assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Give each FunctionApp its own stable task hub instead of sharing the Nox session hub, and verify rewind starts from the intended activity failure. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the test-infrastructure changes targeting host-log parsing and task-hub isolation.
No open issues 🎉
What changed in this PR
This PR addresses Azure Functions E2E flakes from adjacent host log records and sample hosts sharing a task hub. Changes are limited to test infrastructure and coverage; SDK behavior, retry policies, and timeouts remain unchanged.
Changes:
- Extract timestamp-delimited host log records while preserving exact message assertions and category-filter coverage.
- Assign each sample host its own task hub instead of sharing one across the Nox session.
- Add host-free regression tests and require the rewind test’s initial failure to contain the deliberate activity error.
| File | Description |
|---|---|
tests/azure-functions-durable/e2e/test_v1_client_e2e.py |
Verify the expected initial rewind failure and correct the module docstring. |
tests/azure-functions-durable/e2e/test_host_log_records.py |
Cover adjacent log records and preservation of nonmatching output. |
tests/azure-functions-durable/e2e/test_host_isolation.py |
Verify unique, stable task hubs without modifying the parent environment. |
tests/azure-functions-durable/e2e/_harness.py |
Add per-host task hubs and timestamp-based log record extraction. |
noxfile.py |
Remove the session-wide shared task hub setting. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dtask_styleconsumedv1_style'srewind_targetbeforefail_onceran; the accepted rewind was then followed by the activity's first real failure.These changes are confined to E2E infrastructure and tests; no SDK behavior, retry policy, or timeouts change.
Fixes #330.
Fixes #331.