fix: use job type path for on-demand runs - #290
Open
Alon Yeshurun (ayeshurun) wants to merge 1 commit into
Open
Alon Yeshurun (ayeshurun) wants to merge 1 commit into
Alon Yeshurun (ayeshurun) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Alon Yeshurun (ayeshurun)
September 23, 2026 16:12
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes align with the endpoint update and no unresolved issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates on-demand job requests to use /jobs/{jobType}/instances instead of the legacy query parameter.
Changes:
- Updated job endpoint construction.
- Refreshed affected job execution recordings.
- Added a changie release note.
| File | Description |
|---|---|
tests/test_commands/recordings/test_commands/test_jobs/test_start_job_notebook_and_cancel.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_table_maintenance.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_spark_job.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_pipeline.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_param_job.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_job_notebook.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_job_notebook_timeout.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_run_job_notebook_timeout_zero_sec.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_start_text_output_contains_instance_id_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_start_json_output_contains_instance_id_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_run_timeout_cancelled_text_output_contains_instance_id_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_run_timeout_cancelled_json_output_contains_instance_id_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_run_text_output_contains_instance_id_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_run_json_output_contains_instance_id_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_run_failure_with_timeout_exits_with_code_1_success.yaml |
Updated request recording. |
tests/test_commands/recordings/test_commands/test_jobs/test_job_run_exits_with_code_1_success.yaml |
Updated request recording. |
src/fabric_cli/client/fab_api_jobs.py |
Uses the job type path endpoint. |
.changes/unreleased/fixed-20260923-160500.yaml |
Documents the fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
✨ Description of new changes
Update on-demand job requests to use the current
/jobs/{jobType}/instancesendpoint format instead of the legacyjobTypequery parameter.