Remove sudo access to agent shell - #190
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 68.52% 70.73% +2.21%
==========================================
Files 44 44
Lines 2821 2867 +46
==========================================
+ Hits 1933 2028 +95
+ Misses 888 839 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Copilot Add or modify test cases to increase the patch coverage to 100% |
Co-authored-by: 0xba1a <2942888+0xba1a@users.noreply.github.com>
Added targeted regression tests in c6fd492. Local pytest-cov results show 100% patch coverage (68/68 changed executable lines) against the PR base. Full unit selection: 639 passed, 1 skipped. Production code and coverage settings are unchanged. |
| if check_result.return_code != 0: | ||
| logger.debug("📁 Creating destination directory inside container: %s", dest_dir) | ||
| mkdir_cmd = f"mkdir -p {shlex.quote(dest_dir)}" | ||
| mkdir_result = self.execute(mkdir_cmd) |
There was a problem hiding this comment.
might be good to add a comment saying the dest_path shouldn't be root owned path, or change this to execute_privileged.
No description provided.