Repository navigation
MdeModulePkg/PciBusDxe: revert Preserve Physical BAR numbering - #1995
Merged
Aaron (apop5) merged 2 commits intoOct 26, 2026
Merged
Conversation
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/40412038623 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202608 #1995 +/- ##
=================================================
Coverage ? 1.00%
=================================================
Files ? 633
Lines ? 228291
Branches ? 648
=================================================
Hits ? 2290
Misses ? 225969
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Aaron (apop5)
requested review from
kuqin12,
Michael Kubacki (makubacki),
Oliver Smith-Denny (os-d) and
Vineel Kovvuri[MSFT] (vineelko)
October 26, 2026 21:58
kuqin12
approved these changes
Oct 26, 2026
Oliver Smith-Denny (os-d)
approved these changes
Oct 26, 2026
Aaron (apop5)
force-pushed
the
personal/apop5/revertpci
branch
from
October 26, 2026 22:17
a989287 to
d1833e2
Compare
kuqin12
approved these changes
Oct 26, 2026
Aaron (apop5)
enabled auto-merge (rebase)
October 26, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert the changes because 2 existing video option roms have been found to be broken by this functionality.
This UEFI specification will need to be updated to include information about compacted bars because today the specification implies that the BarIndex passed into PciIo functions matches the physical BAR numbering in config space.
Reverting change that is being reverted in upstream: tianocore/edk2#13376
How This Was Tested
With change in place, 2 GOP option roms were failing to allow video output.
After reverting, option roms were successful
Integration Instructions
No Integration necessary