Skip to content

[2511] NetworkPkg/UefiPxeBcDxe: Clear UDP read events after closing - #1999

Merged
Michael Kubacki (makubacki) merged 1 commit into
microsoft:release/202511from
makubacki:cp_pxe_udp_token_null_cleanup_2511
Oct 28, 2026
Merged

Michael Kubacki (makubacki) merged 1 commit into
microsoft:release/202511from
makubacki:cp_pxe_udp_token_null_cleanup_2511

Conversation

@makubacki

Copy link
Copy Markdown
Member

Description

EfiPxeBcUdpRead() closes the UDP completion event but leaves its handle in PXEBC_PRIVATE_DATA. A subsequent EfiPxeBcStop() can close the stale handle again, causing an exception in CoreCloseEvent().

Clear the IPv4 and IPv6 token event handles after closing them so Stop only closes events that are still live.

(cherry picked from release/202608 commit 7d204c6)

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • Testing is based on the 2608 commit testing.

Integration Instructions

  • N/A

EfiPxeBcUdpRead() closes the UDP completion event but leaves its handle
in PXEBC_PRIVATE_DATA. A subsequent EfiPxeBcStop() can close the stale
handle again, causing an exception in CoreCloseEvent().

Clear the IPv4 and IPv6 token event handles after closing them so Stop
only closes events that are still live.

Signed-off-by: Sureshkumar Ponnusamy <sponnusamy@microsoft.com>
(cherry picked from release/202608 commit 7d204c6)
@makubacki

Copy link
Copy Markdown
Member Author

Note: I didn't include [CHERRY-PICK] in the commit message or "Squash on Rebase" since it's not cherry-picked from edk2 and this branch has already been rebased for 2608. The cherry-pick line at the end is just to track that it's already in 2608 and coming from there.

@mu-automation

mu-automation Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

⏩ QEMU Validation Skipped

Validation was skipped (reason: wrong_target_branch).

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@33e530b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/202511   #1999   +/-   ##
================================================
  Coverage                  ?   0.65%           
================================================
  Files                     ?     165           
  Lines                     ?   72350           
  Branches                  ?    1787           
================================================
  Hits                      ?     476           
  Misses                    ?   71864           
  Partials                  ?      10           
Flag Coverage Δ
NetworkPkg 0.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki
Michael Kubacki (makubacki) merged commit 9067996 into microsoft:release/202511 Oct 28, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants