Repository navigation
[CHERRY-PICK][REBASE & FF] Pick up EDK2 version of decoupling core private structure - #2004
Conversation
…ore mailbox data" This reverts commit f498d0f. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/40950088502 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Current `gSmmCorePrivate` data used in PiSmmCore is a shared data structure initialized and used by PiSmmIpl. Thus the content is exposed to normal DXE environment. Specifically, `SmmDispatcher` actively uses `gSmmCorePrivate` to determine dispatch behavior. As a result, the potential attack surface is exposed from SMM initialization through the SMM Ready-to-Lock event. This change decouple Core private data from and IPL mailbox at the entrypoint of each MMI handle routine. It is a preventative fix to eliminate hot access to gSmmCorePrivate within the SMM core. Signed-off-by: Kun Qin <kun.qin@microsoft.com> (cherry picked from commit 3b54a25765919289f1bc38261b6b2bddb7b20a21)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202608 #2004 +/- ##
=================================================
Coverage ? 1.00%
=================================================
Files ? 633
Lines ? 228294
Branches ? 648
=================================================
Hits ? 2290
Misses ? 225972
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
kuqin12 after this merges, you plan on updating the mm_supv override hashes? that is the q35 failure... |
No, the override hashes are gone. My plan is to update the supv from platform side and make a release. Then this one will resolve automatically. |
This is done and PR validation is functional now. |
Description
This change picks up the upstreamed version of decoupling SMM core private structure commit.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested on OVMF with traditional MM configuration.
Integration Instructions
N/A