Skip to content

[CHERRY-PICK][REBASE & FF] .pytool: Image Validation Plugin: Drop Zero ImageBase Requirement - #2005

Merged
kuqin12 merged 1 commit into
microsoft:release/202608from
kuqin12:relax_base
Oct 30, 2026
Merged

kuqin12 merged 1 commit into
microsoft:release/202608from
kuqin12:relax_base

Conversation

@kuqin12

@kuqin12 kuqin12 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Description

  • Zero ImageBase requirement is dropped from Image validation plugin as it is not enforced by most PE loaders in UEFI.
  • Patina in particular dropped support for producing .efi files with zero ImageBase
  • This also improves the debugging experience when using WinDbg

(cherry picked from commit a3a9cc8)

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This fixed a build break on the patina core that retains the non-zero base address.

Integration Instructions

N/A

@mu-automation

mu-automation Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

Source Dependencies

Repository Commit
mu_basecore 4e40936
mu_tiano_platforms f09c46b

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 19s Build Logs Boot Logs
ArmVirt DEBUG ✅ success ✅ success 0m 13s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/40979097031

This comment was automatically generated by the Mu QEMU PR Validation workflow.

- Zero ImageBase requirement is dropped from Image validation plugin as it is
  not enforced by most PE loaders in UEFI.
- Patina in particular dropped support for producing .efi files with zero
  ImageBase
- This also improves the debugging experience when using WinDbg

Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
(cherry picked from commit a3a9cc8)
@kuqin12 kuqin12 changed the title [CHERRY-PICK] .pytool: Image Validation Plugin: Drop Zero ImageBase Requirement [CHERRY-PICK][REBASE & FF] .pytool: Image Validation Plugin: Drop Zero ImageBase Requirement Oct 30, 2026
@kuqin12
kuqin12 enabled auto-merge (rebase) October 30, 2026 00:13
@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202608@b44155b). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202608    #2005   +/-   ##
=================================================
  Coverage                  ?    1.90%           
=================================================
  Files                     ?     1675           
  Lines                     ?   423792           
  Branches                  ?     5224           
=================================================
  Hits                      ?     8083           
  Misses                    ?   415607           
  Partials                  ?      102           
Flag Coverage Δ
FmpDevicePkg 9.63% <ø> (?)
MdeModulePkg 1.00% <ø> (?)
MdePkg 5.44% <ø> (?)
NetworkPkg 0.66% <ø> (?)
PolicyServicePkg 30.42% <ø> (?)
SecurityPkg 1.55% <ø> (?)
StandaloneMmPkg 0.50% <ø> (?)
UefiCpuPkg 4.70% <ø> (?)
UnitTestFrameworkPkg 11.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuqin12
kuqin12 merged commit 64f4789 into microsoft:release/202608 Oct 30, 2026
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants