Repository navigation
MsGraphicsPkg: Use verbose logging for QR encoding traces - #949
Closed
Lee HoJoon (guosasipo) wants to merge 1 commit into
Closed
Lee HoJoon (guosasipo) wants to merge 1 commit into
Lee HoJoon (guosasipo) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QrEncoderLib emits routine algorithm and progress diagnostics at DEBUG_INFO even when the caller passes Flags = 0. When a firmware application exports AdvancedLogger through rotating QR codes, rendering each page adds these diagnostics to the same buffer. Reopening the viewer then exports its own encoding trace, causing rapid page-count growth.
Move unconditional version, masking, penalty, format/version-bit and progress traces to DEBUG_VERBOSE. Pass the level through the private PrintBinary helper so explicitly requested QR_FLAGS_DEBUG_* output remains at DEBUG_INFO. Preserve DEBUG_ERROR and invalid-input diagnostics. No encoding algorithm or public API changes.
How This Was Tested
The host regression harness is not included in this focused source-only change.
Integration Instructions
Enable DEBUG_VERBOSE when routine encoding traces are needed. Existing explicit QR debug flags remain supported.