Repository navigation
Update Requests security fixes and align the Python requirement - #165
Merged
Merged
Conversation
LakshyAAAgrawalP
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Requests from 2.32.3 to 2.33.0 in both dependency manifests, fixing the two advisories currently reported against those pins:
Compatibility change: Requests 2.33.0 requires Python 3.10+. Raise multilspy's package metadata to match and make the requirement explicit in the installation documentation. CI already tests Python 3.10, 3.12, and 3.14. This replaces the dependency-only update proposed in #151 with consistent Python compatibility metadata; Python 3.8/3.9 are no longer supported by this change.
Validation: built the wheel and verified its Requires-Python and Requests dependency metadata. Installed it with the requirements in clean Python 3.10 and 3.14 environments; dependency checks and four real Jedi/Black integration tests pass on each. On both interpreters, also exercised FileUtils.download_file against an HTTP server, verifying a 1 MiB binary stream byte-for-byte and rejection of HTTP 404.