Skip to content

FIx CI, again - #430

Merged
Thom Chiovoloni (thomcc-work) merged 2 commits into
mainfrom
thomcc/fix-ci-again
Oct 26, 2026
Merged

Thom Chiovoloni (thomcc-work) merged 2 commits into
mainfrom
thomcc/fix-ci-again

Conversation

@thomcc-work

Copy link
Copy Markdown
Contributor

Fallout from #426 :(

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

2 open issues
What changed in this PR

Aligns Docker image SSRF/HTTP allowlist configuration with the local runner and updates CI triggers after changes introduced in #426.

Changes:

  • Expands pg_durable.http_allowed_domains in the Docker image to include additional Azure-related domains.
  • Adds a regression test to ensure the Docker image allowlist matches the local runner’s allowlist.
  • Updates the Docker GitHub Actions workflow path filters to rerun when allowlist/SSRF inputs change.
File Description
tests/​test_docker_runner.py Adds a test that compares Dockerfile vs local script allowlist values.
Dockerfile Updates pg_durable.http_allowed_domains to include additional domains.
.github/​workflows/​docker.yml Ensures Docker workflow reruns when allowlist sources change.

Review effort: Lite

Comment thread tests/test_docker_runner.py Outdated
Comment thread tests/test_docker_runner.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped configuration fix, regression test, and CI triggers are consistent, with no unresolved issues identified.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@thomcc-work
Thom Chiovoloni (thomcc-work) merged commit e3c7b86 into main Oct 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants