Skip to content

feat: add hasAttribute(name) for attribute presence assertions #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JAYA DILEEP (seethinajayadileep) wants to merge 2 commits into
base: main
Choose a base branch
from
+33 −0
Open

feat: add hasAttribute(name) for attribute presence assertions #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa7f162
feat: add hasAttribute(name) for attribute presence assertions
seethinajayadileep Sep 5, 2026
644b252
refactor: drop hand-edited LocatorAssertions API
seethinajayadileep Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,18 @@ private void hasAttribute(String name, ExpectedTextValue expectedText, Object ex
expectImpl("to.have.attribute.value", expectedText, expectedValue, message, commonOptions, "Assert \"hasAttribute\"");
}

@Override
public void hasAttribute(String name, HasAttributeOptions options) {
if (options == null) {
options = new HasAttributeOptions();
}
FrameExpectOptions commonOptions = convertType(options, FrameExpectOptions.class);
commonOptions.expressionArg = name;
String message = "Locator expected to have attribute '" + name + "'";
List<ExpectedTextValue> expectedText = null;
expectImpl("to.have.attribute", expectedText, null, message, commonOptions, "Assert \"hasAttribute\"");
}

@Override
public void hasClass(String text, HasClassOptions options) {
ExpectedTextValue expected = new ExpectedTextValue();
Expand Down
21 changes: 21 additions & 0 deletions playwright/src/test/java/com/microsoft/playwright/TestLocatorAssertions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,27 @@ void hasAttributeRegExpFail() {
assertTrue(e.getMessage().contains("Locator expected to have attribute 'id' matching regex\nExpected: .Nod..\nReceived: node"), e.getMessage());
}

@Test
void hasAttributeNamePass() {
page.setContent("<div checked id=node>Text content</div>");
Locator locator = page.locator("#node");
assertThat(locator).hasAttribute("id");
assertThat(locator).hasAttribute("checked");
assertThat(locator).not().hasAttribute("open");
}

@Test
void hasAttributeNameFail() {
page.setContent("<div checked id=node>Text content</div>");
Locator locator = page.locator("#node");
AssertionFailedError e = assertThrows(AssertionFailedError.class,
() -> assertThat(locator).hasAttribute("disabled", new LocatorAssertions.HasAttributeOptions().setTimeout(1000)));
assertTrue(e.getMessage().contains("Locator expected to have attribute 'disabled'"), e.getMessage());
e = assertThrows(AssertionFailedError.class,
() -> assertThat(locator).not().hasAttribute("checked", new LocatorAssertions.HasAttributeOptions().setTimeout(1000)));
assertTrue(e.getMessage().contains("Locator expected not to have attribute 'checked'"), e.getMessage());
}

@Test
void hasClassTextPass() {
page.setContent("<div class=\"foo bar baz\"></div>");
Expand Down