Repository navigation
fix: open the running app instead of starting another copy - #105
Open
TNguyen1228 wants to merge 1 commit into
Open
TNguyen1228 wants to merge 1 commit into
TNguyen1228 wants to merge 1 commit into
Conversation
Each launch from the desktop or Start menu shortcut started a full second Skill Recorder: another main process with its own tray icon, windows and recorder, while the global shortcut could only belong to the first one. Take Electron's single-instance lock at startup. A later launch exits before creating any window, and the running copy comes to the front on "second-instance", the same way a Dock click does on macOS: the recording bar while recording, otherwise the recorder window (restored if minimized). Note: when a new revision is installed while an older one is still open, the new launch now hands over to the open copy, so quit it first.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each launch from the desktop or Start menu shortcut started a full second Skill Recorder: another main process with its own tray icon, windows and recorder, while the global shortcut could only belong to the first one.
Take Electron's single-instance lock at startup. A later launch exits before creating any window, and the running copy comes to the front on "second-instance", the same way a Dock click does on macOS: the recording bar while recording, otherwise the recorder window (restored if minimized).
Note: when a new revision is installed while an older one is still open, the new launch now hands over to the open copy, so quit it first.