Implement multi-range document formatting - #14776
Merged
Colen Garoutte-Carson (Colengms) merged 2 commits intoSep 18, 2026
Merged
Colen Garoutte-Carson (Colengms) merged 2 commits into
Colen Garoutte-Carson (Colengms) merged 2 commits into
Conversation
Colen Garoutte-Carson (Colengms)
marked this pull request as ready for review
September 17, 2026 02:23
Colen Garoutte-Carson (Colengms)
requested a review
from a team
as a code owner
September 17, 2026 02:23
Sean McManus (sean-mcmanus)
approved these changes
Sep 17, 2026
Copilot started reviewing on behalf of
Colen Garoutte-Carson (Colengms)
September 18, 2026 01:28
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The native formatter must consume ranges, or additional requested ranges will be dropped.
Review effort: Lite
Findings: None
What changed in this PR
Adds multi-range document formatting support while preserving single-range compatibility.
Changes:
- Shares formatting logic between singular and plural providers.
- Sends all requested ranges through an optional
rangesfield. - Preserves the existing
rangefield.
| File | Description |
|---|---|
Extension/src/LanguageServer/Providers/documentRangeFormattingEditProvider.ts |
Adds plural formatting support and serializes multiple ranges. |
Extension/src/LanguageServer/client.ts |
Extends formatting parameters with optional ranges. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Colen Garoutte-Carson (Colengms)
deleted the
dev/coleng/provideDocumentRangesFormattingEdits
branch
September 18, 2026 01:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
provideDocumentRangesFormattingEditsand sends all requested ranges in onecpptools/formatRangerequest.The singular and plural providers now share the same formatting path. The existing
rangefield remains populated for compatibility, while the new optionalrangesfield carries the complete request.A companion native change is required.
Validation:
yarn build