fix(deps): remove unused vscode-languageclient - #1682
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
8c768be to
8714d16
Compare
Bumps [vscode-languageclient](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client) from 6.0.0-next.9 to 10.1.0. - [Release notes](https://github.com/Microsoft/vscode-languageserver-node/releases) - [Commits](https://github.com/Microsoft/vscode-languageserver-node/commits/release/client/10.1.0/client) --- updated-dependencies: - dependency-name: vscode-languageclient dependency-version: 10.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8714d16 to
d941ce3
Compare
Replace private vscode-languageclient converter imports that are no longer exported in v10 and cover the equivalent range conversion behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the v10 migration removes unsupported private converter imports, preserves range conversion behavior, and passes the full CI matrix.
There was a problem hiding this comment.
🟡 Changes recommended
vscode-languageclient appears to be unused after the refactor (no remaining repo references), so keeping/bumping it adds avoidable dependency and supply-chain surface.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the extension’s dependency set by bumping vscode-languageclient to 10.1.0, while removing reliance on its internal range converters by introducing local VS Code ↔︎ LSP Range conversion helpers and adding a regression test for those helpers.
Changes:
- Bump
vscode-languageclientfrom6.0.0-next.9to10.1.0(plus transitive dependency updates in the lockfile). - Replace usage of
vscode-languageclient/lib/*Converterinternals with localtoProtocolRange/toCodeRangehelpers. - Add a unit test validating the range conversion behavior.
File summaries
| File | Description |
|---|---|
| test/JavaInlineValueProvider.test.ts | Adds coverage for VS Code ↔︎ protocol Range conversions. |
| src/JavaInlineValueProvider.ts | Removes dependency on vscode-languageclient internal converters and uses local conversion helpers. |
| package.json | Bumps vscode-languageclient version. |
| package-lock.json | Updates resolved dependency tree for the vscode-languageclient bump. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Withdrawing approval because vscode-languageclient is unused after the converter refactor and should be removed rather than upgraded.
The inline range conversion no longer relies on vscode-languageclient, leaving no runtime, build, test, type, or configuration usage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the focused vscode-languageclient removal while incorporating current main dependency updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The dependency removal is complete (no remaining references found) and the replacement conversions are straightforward and covered by a regression test.
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
The unused direct dependency is removed, the replacement range conversion is covered, and all required checks pass on the current head.
Removes the unused direct runtime dependency
vscode-languageclient(6.0.0-next.9-> removed).The extension only used private range-conversion helpers from the package. Those calls are replaced with focused local conversions backed by regression coverage, leaving no runtime, build, test, type, configuration, packaging, or dynamic usage of
vscode-languageclient.Validation completed on Node.js 20:
npm cinpm run tslintnpm run compilenpm run buildnpm test(34 passing)