Repository navigation
Write Code 11 check digit K as a dash when the value is 10 - #215
Merged
Merged
Conversation
The C digit already used a dash. K was appended as the two characters 10, and the stop code was left off.
Owner
|
Merged manually onto master after resolving a test conflict with #214 (both PRs touched DNS1DTest). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code 11 check digit C already turns a value of 10 into
-. Check digit K appended the integer 10, which is the two characters1and0, and the stop code was left off.00000000007has C = 7 and K = 10. The bars wereS00000000007710. They should beS000000000077-S. A value of K from 0 through 9 is unchanged:00000000001is stillS0000000000113S.The new case failed on master (
S000000000077-SversusS00000000007710) and passes once K uses the same dash as C.Test plan
vendor/bin/phpunit --filter DNS1DTest(7 tests, 21 assertions)Made with Cursor