Repository navigation
fix(deps): bump katex to 0.18 to resolve prototype pollution advisory - #1107
Merged
Merged
Conversation
Add an override so the copies pulled in by @streamdown/math, mermaid and rehype-katex resolve to the same patched version as the stylesheet.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Dependabot alert for the KaTeX prototype pollution advisory (patched in 0.18.2).
katexdependency from^0.16.10to^0.18.2(resolves to 0.18.11).katextooverridesso the transitive copies from@streamdown/math,mermaidandrehype-katex(all on^0.16.x) resolve to the same patched version. Without the override the renderer stays on 0.16.44 and the alert is not actually fixed.Keeping one version also matters because the app imports
katex/dist/katex.min.cssdirectly while@streamdown/mathdoes the rendering, so the stylesheet and renderer should come from the same release.Risk
The advisory is low severity: it only applies when
Object.prototypeis already polluted, and Morphic passes fixed renderer options. This is a hygiene fix.The 0.17/0.18 breaking changes are an internal
__defineFunctionAPI change and CSS class prefixing; neither affects how Morphic uses KaTeX.Verification
bun lint,bun typecheck,bun format:check,bun run buildpassbun run testpassesWritten with an agent (Claude Code, claude-opus-5-5).