Repository navigation
feat(draft): suggest revisions at the end of draft answers - #1111
Merged
Merged
Conversation
Replace the related questions prompt with a general follow-up suggestions block whose heading, icon, and content fit the answer: follow-up questions under "Related" for an answer that informs, and changes to the draft under "Revise" with an edit icon for a draft answer.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft answers rarely end with suggestions today, far less often than other answers, and the ones that do carry questions about the topic for the article's reader, not anything the writer would do next. Follow-up requests on drafts are mostly the same few shapes (shorten it, make it more formal or more human, rework a named paragraph, translate it), so they are easy to offer as buttons.
This replaces the related questions prompt with one general follow-up suggestions block instead of adding a draft-specific concept:
related) for an answer that informs, and three changes to the draft under "Revise" (iconedit, new) for a draft answer, phrased as the user's own instruction and anchored to the draft's purpose, audience, or parts.submitQuery, so clicks still send the suggestion as the next message and recordrelated_question_clicked.submitQuerybuttons rather than by therelatedicon, both when history is stripped of old spec blocks and in the evals, so a heading with another icon is kept and counted. Existing history only holds related blocks, so the stripped prefix is unchanged for it.### Reviseas markdown above the block, so the heading showed twice. The related questions evaluator now flags that as malformed.Evals
eval:draft-edits(32 items, 3 trials, synthetic plus local production seeds):editiconeval:related-questions(5 trials), against the committed thresholds:The new draft metrics are added to
thresholds.jsonas reported but not enforced.Checked in the app
On
bun dev: a draft answer shows "Revise" with a pencil icon and three changes; clicking "Make the tone firmer but still polite" raneditDraft(v2) and that answer got its own suggestions. A researched answer still shows "Related". No console errors.Checks
bun lint,bun typecheck,bun format:check,bun run build, andbun run testpass.Written with an agent (Claude Code, claude-opus-5-5).