Fix eval cleanup deadlock by committing GPU streams before waiting - #4556
Open
ronaldmannak wants to merge 2 commits into
Open
ronaldmannak wants to merge 2 commits into
ronaldmannak wants to merge 2 commits into
Conversation
ronaldmannak
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception-cleanup path added in #3675 can deadlock when evaluation throws after a CPU stream has queued a wait on uncommitted GPU work.
This PR commits all open GPU streams before syncing any stream. I've added
test_eval_exception_after_cross_stream_waitwhich will hang without the fix