Skip to content

Raise python version to 3.10 - #225

Open
mihncalo wants to merge 3 commits into
mlcommons:mainfrom
Keysight:build/issue-224-raise-requires-python
Open

mihncalo wants to merge 3 commits into
mlcommons:mainfrom
Keysight:build/issue-224-raise-requires-python

Conversation

@mihncalo

@mihncalo mihncalo commented Oct 22, 2026 •

Copy link
Copy Markdown

Summary

Raised requires-python from 3.7 to 3.10 to prepare the environment for the changes in PR #217
Raised ruff target-version from py39 to py310 to match the new python requirement

Test Plan

Environment: python 3.10.12

pip install -r requirements-dev.txt
ruff check . -> Output: All checks passed!
python -m pytest -vv tests -> Output: All 117 tests passed

Closes #224

@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Comment thread src/converter/pytorch_node.py Resolved
Comment thread pyproject.toml Resolved
@mihncalo
mihncalo marked this pull request as ready for review October 22, 2026 13:49
@theodorbadea

Copy link
Copy Markdown
Contributor

lgtm

@jinsun-yoo jinsun-yoo changed the title Build/issue 224 raise requires python Raise python and ruff version to 3.10 and py310, each Oct 25, 2026

@jinsun-yoo jinsun-yoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mihncalo Please have a look at this comment. Thanks.

Comment thread src/converter/pytorch_node.py Resolved
@jinsun-yoo

Copy link
Copy Markdown
Contributor

Also changed PR title

@mihncalo mihncalo changed the title Raise python and ruff version to 3.10 and py310, each Raise python version to 3.10 Oct 27, 2026
@winstonliu1111
winstonliu1111 removed the request for review from TaekyungHeo October 27, 2026 17:28

@jinsun-yoo jinsun-yoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinsun-yoo jinsun-yoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one question: Ref: #217. Why not pin to 3.11?

@mihncalo

Copy link
Copy Markdown
Author

Actually, one question: Ref: #217. Why not pin to 3.11?

I picked 3.10 ( even though, indeed, it's quite old ) because it's the minimum that traceinsight requires, and it's also the default Python on Ubuntu 22.04, so it keeps the widest range of supported environments working.

We can pin to 3.11 now if you'd like, or do it after the first release, once we know whether anyone is still relying on the older baseline. What do you think?

@theodorbadea

Copy link
Copy Markdown
Contributor

Seems more than reasonable. 3.11 gives us one year until will get in end-of-life status and would also fit with the pandas 3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise requires-python to >=3.10

3 participants