Repository navigation
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…e and ran ruff format
|
lgtm |
jinsun-yoo
left a comment
There was a problem hiding this comment.
Hi @mihncalo Please have a look at this comment. Thanks.
|
Also changed PR title |
jinsun-yoo
left a comment
There was a problem hiding this comment.
Actually, one question: Ref: #217. Why not pin to 3.11?
I picked 3.10 ( even though, indeed, it's quite old ) because it's the minimum that We can pin to 3.11 now if you'd like, or do it after the first release, once we know whether anyone is still relying on the older baseline. What do you think? |
|
Seems more than reasonable. 3.11 gives us one year until will get in end-of-life status and would also fit with the pandas 3 version. |
Summary
Raised requires-python from 3.7 to 3.10 to prepare the environment for the changes in PR #217
Raised ruff target-version from py39 to py310 to match the new python requirement
Test Plan
Environment: python 3.10.12
pip install -r requirements-dev.txt
ruff check . -> Output: All checks passed!
python -m pytest -vv tests -> Output: All 117 tests passed
Closes #224