Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture Windows local validation build binlogs
Preserve MSBuild logs from Windows local validation builds.
Description
Enable binary logging for the No NodeJS, Debug, and Release build steps in the public, official, and unofficial Windows local-validation jobs. The jobs intentionally run without
-ci, so the build script does not otherwise enable its default binlogger. The existing attempt-specific artifact upload already runs after a failed step.Each MSBuild invocation uses a unique, step-specific filename under
artifacts/log/. This preserves both native and managed build logs without later steps overwriting them. The quoted{}placeholder is passed through the PowerShell wrapper to MSBuild's unique-name expansion.This is a diagnostic change, not a fix for the file lock. A future binlog can help identify overlapping targets or producers; a separate handle trace may still be needed to identify the process holding a file. Logging adds build I/O and artifact size, but is limited to this validation job and does not add retries or change failure handling.
Validation
python .\check.py green(session-only Windows harness, with the repository environment activated and the workspace and systemdotnet.execonfigured): passed 27 cases. It exercised the actualeng/build.ps1andeng/build.cmdentry points with a small injected MSBuild project. Across all three pipeline definitions, 18 native/managed failure scenarios generated distinct binlogs, and nine successful build steps preserved earlier logs. The corresponding 18 scenarios reproduced the missing artifact before the change.MSB3491. The baseline left the artifact directory without a binlog; the changed Release command retained separate native and managed binlogs, and the managed binlog contained the file-lock error.git -c core.longpaths=true diff --check: passed.Relates to #31.