Skip to content

fix(train): fail fast on incompatible DLRover flash checkpoint APIs - #9964

Merged
tastelikefeet merged 2 commits into
modelscope:mainfrom
Excelius-Wang:fix/dlrover-flash-ckpt-compat
Aug 26, 2026
Merged

fix(train): fail fast on incompatible DLRover flash checkpoint APIs#9964
tastelikefeet merged 2 commits into
modelscope:mainfrom
Excelius-Wang:fix/dlrover-flash-ckpt-compat

Conversation

@Excelius-Wang

Copy link
Copy Markdown
Contributor

Summary

  • validate the DLRover Flash Checkpoint API before loading the model
  • fail fast with an actionable source-install command when blocking or max_steps is unavailable
  • add regression tests for the released DLRover 0.6.1 API and the current source API

Motivation

The latest published DLRover release, 0.6.1, does not accept the blocking and max_steps arguments used by ms-swift. The incompatibility is currently discovered only while saving a checkpoint or shutting down training.

Silently dropping these arguments would be unsafe because blocking=True prevents the final checkpoint from being skipped while a previous asynchronous save holds the shared-memory lock. This change keeps the current checkpoint semantics and reports the incompatible dependency before model loading.

Validation

  • focused unit tests: 2 passed
  • project test runner: 2/2 passed
  • all relevant pre-commit hooks passed
  • git diff --check passed

Related to #9912.

Comment thread swift/trainers/mixin.py Outdated
@tastelikefeet
tastelikefeet merged commit 24f2941 into modelscope:main Aug 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants