fix(train): fail fast on incompatible DLRover flash checkpoint APIs - #9964
Merged
tastelikefeet merged 2 commits intoAug 26, 2026
Merged
Conversation
tastelikefeet
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockingormax_stepsis unavailableMotivation
The latest published DLRover release, 0.6.1, does not accept the
blockingandmax_stepsarguments used by ms-swift. The incompatibility is currently discovered only while saving a checkpoint or shutting down training.Silently dropping these arguments would be unsafe because
blocking=Trueprevents the final checkpoint from being skipped while a previous asynchronous save holds the shared-memory lock. This change keeps the current checkpoint semantics and reports the incompatible dependency before model loading.Validation
git diff --checkpassedRelated to #9912.