feat(quota): split --delete into a dedicated quota delete command - #186
Closed
gujieye wants to merge 1 commit into
Closed
feat(quota): split --delete into a dedicated quota delete command#186gujieye wants to merge 1 commit into
gujieye wants to merge 1 commit into
Conversation
The destructive --delete flag sat on "quota update", but the --yes high-risk confirmation guards command paths rather than individual flags. Promote it to its own "quota delete" command with a --yes guardrail, and reduce "quota update" to QPM/TPM updates only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The destructive
--deleteflag previously lived onbl quota update, but the--yeshigh-risk confirmation guards command paths rather than individual flags. This PR promotes the flag to its own command:bl quota delete --model <model> [--yes]— clears all custom QPM/TPM limits via the model-limits API (operation_type: "DELETE"), with the same--yesconfirmation guardrail as finetune/deploy/dataset delete.--dry-runemits the DELETE request shape.bl quota updateis reduced to QPM/TPM updates only: the--delete/--yesflags, related notes, and examples are removed; validation returns to "one of --rpm / --tpm is required"; a note points users toquota delete.quota requestremains a backward-compatible alias ofquota update.Breaking change
quota update --deleteno longer parses and now errors withUnknown flag "--delete". Usequota deleteinstead.Test plan
pnpm run check(format + lint + typecheck) passesvp test packages/commands/tests/e2e/quota.e2e.test.ts— help/validation/dry-run/non-TTY confirm cases for both commandsvp test packages/cli/tests/e2e/registry.smoke.e2e.test.ts— 204 passing