Repository navigation
fix: follow redirects when checking the latest release - #37
Merged
Merged
Conversation
The MODFLOW-USGS org is now MODFLOW-ORG, and the GitHub API answers the old owner with a 301 that curl didn't follow. The release check then parsed the redirect body, failed with KeyError: 'assets', and fell back to an empty code.json, so the cache key ignored the release's metadata. Follow redirects, fail on HTTP errors, and tolerate a response without assets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accommodate MODFLOW-USGS -> MODFLOW-ORG rename, which was causing 301s from the GH API. follow redirects, fail on HTTP errors, and tolerate a response without assets