Repository navigation
build: Module boundaries were preserved in package output - #7
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 851 851
Branches 191 191
=========================================
Hits 851 851 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build emitted implementations such as
assertions-HASH.mjsbehind public entrypoint facades. Preserve source module boundaries soassertions.mjsand the other named modules contain their implementations and serve as shared dependencies in both ESM and CJS output.preserveModulesRootkeeps paths relative tosrc. Internal modules are emitted as separate, stably named files; package exports remain unchanged.The packed consumer check now rejects hashed runtime chunks, verifies direct imports through the public assertions and predicates modules, and checks that every assertion has the same identity through the root and assertions entrypoints.
Validation:
yarn lint,yarn typecheck,yarn test(235 tests, 100% coverage),yarn build, and packed consumer checks for ESM/CJS, strict NodeNext/Bundler types, and tree shaking. Packed consumer checks ran outside the sandbox because child npm processes were blocked with EPERM.