ci: replace assert-and-fail with real apt-get install for ffmpeg/libsndfile - #180
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
unfoundbox
force-pushed
the
ci/install-system-packages
branch
from
September 25, 2026 06:03
1340b48 to
f2abe78
Compare
…sn't have them The first hosted-ubuntu run of this repo measured the assumption wrong: ffmpeg and libsndfile1 are NOT stock on ubuntu-latest (they were on lenovo-spacepilot, which is why the 'verify only' step had worked there). Assert-and-fail is the wrong response on a hosted runner where the fix is one apt-get away. Replace both occurrences with the actual install.
unfoundbox
force-pushed
the
ci/install-system-packages
branch
from
September 25, 2026 06:10
f2abe78 to
b5ede8d
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #178, which moved the suite to hosted runners but retained the lenovo-era verify-only step. The assumption was wrong (measured on PR #178's first hosted run): ubuntu-latest does not ship ffmpeg/libsndfile by default.
Both job steps (pytest, packaging) replaced with the actual install. No scope change anywhere, no system package added by hand anywhere.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.