Update llama.cpp submodule to 9723942 - #21
Merged
Conversation
Contributor
Author
|
🔨 CI triggered manually: https://github.com/mozilla-ai/agent.cpp/actions/runs/33345929214 |
Upstream llama.cpp moved its vendored headers behind `vendor::*` interface targets and renamed the `common` library to `llama-common`. Linking the now-nonexistent `common` target silently degraded to `-lcommon`, so the nlohmann include directory was no longer propagated and every target that includes <nlohmann/json.hpp> failed to compile. Resolve the target name once (falling back to `common` for older pins) and use it everywhere, including the standalone example projects. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the llama.cpp submodule from
389ff61to9723942.Changes: ggml-org/llama.cpp@389ff61...9723942
This PR was automatically created by the update-llama-cpp workflow.