Conversation
Contributor
Author
|
Could this be reviewed? Or, if you would prefer a separate rule then let me know? |
marco-c
reviewed
Sep 23, 2026
Comment on lines
+191
to
+193
| "f5": "status_whiteboard", | ||
| "o5": "notsubstring", | ||
| "v5": "[checkin-needed-beta]", |
Contributor
There was a problem hiding this comment.
Is it OK to keep this if we want to also handle ESR?
marco-c
reviewed
Sep 23, 2026
Comment on lines
176
to
+185
| # Don't nag several times | ||
| "n5": 1, | ||
| "f5": "longdesc", | ||
| "o5": "casesubstring", | ||
| "v5": COMMENT_MARKER, | ||
| "n2": 1, | ||
| "f2": "longdesc", | ||
| "o2": "casesubstring", | ||
| "v2": COMMENT_MARKER, | ||
| # Same, for bugs nagged with the previous wording | ||
| "n8": 1, | ||
| "f8": "longdesc", | ||
| "o8": "casesubstring", | ||
| "v8": LEGACY_COMMENT_MARKER, | ||
| "n3": 1, | ||
| "f3": "longdesc", | ||
| "o3": "casesubstring", | ||
| "v3": LEGACY_COMMENT_MARKER, |
Contributor
There was a problem hiding this comment.
Same question here. If we nagged before for beta, we don't want to nag anymore even if it's for ESR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently uplift_beta only adds a needinfo when beta is affected or fix-optional. ESR gets mentioned in that comment if the current ESR is also affected.
If beta is wontfix, then no needinfo is ever added, even when ESR is still affected. With the change in release frequency, this is a more common scenario.
I could implement this as a new rule, but thought it worth adding to uplift_beta first for a review
Checklist
to-be-announcedtag added if this is worth announcing