Move action handlers to hackbot api - #6802
Open
ayoubdiourin7 wants to merge 5 commits into
Open
Conversation
Comment on lines
+25
to
+33
| def _git(repo, *args: str) -> str: | ||
| """Run a git command in ``repo`` and return its stdout.""" | ||
| return subprocess.run( | ||
| ["git", "-C", str(repo), *args], | ||
| check=True, | ||
| capture_output=True, | ||
| text=True, | ||
| ).stdout | ||
|
|
Member
There was a problem hiding this comment.
Why do we need this here? The hackbot-api service does not have a git repo!
Comment on lines
+36
to
+37
| # Email-body token replaced with the source-code patch. | ||
| PATCH_PLACEHOLDER = "{patch}" |
Comment on lines
+20
to
+21
| # Actions that submit source changes to Phabricator. | ||
| PATCH_ACTION_TYPES = frozenset({"phabricator.submit_patch", "phabricator.update_patch"}) |
Member
There was a problem hiding this comment.
Is this a duplicate now? If so, we should file a follow-up issue and link it here, so we could fix that later.
If we have other cases, we could use the same issue to track all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit by commit:
Fixes #6754