Skip to content

Follow up fix for #187 - #188

Open
cracksalad wants to merge 1 commit into
msgpack:masterfrom
cracksalad:master
Open

Follow up fix for #187#188
cracksalad wants to merge 1 commit into
msgpack:masterfrom
cracksalad:master

Conversation

@cracksalad

Copy link
Copy Markdown
Contributor

This is a follow up of #187
Added a test case to cover backed enums as well. The proper solution is way easier than the one I wrote last time. Sorry for messing this up.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.65%. Comparing base (35d4381) to head (26c8c70).
⚠️ Report is 8 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   68.51%   68.65%   +0.13%     
==========================================
  Files           7        7              
  Lines        1350     1356       +6     
  Branches      247      248       +1     
==========================================
+ Hits          925      931       +6     
  Misses        310      310              
  Partials      115      115              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants