Repository navigation
Fix automation HTTP reads across peer shutdown on macOS - #55
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production release run exposed an intermittent macOS HTTP error when the peer closed before the client finished reading: changing socket timeouts during reads could fail with EINVAL despite a buffered response. Accepted sockets also have platform-dependent nonblocking inheritance.
Configure every connection as nonblocking once before exchanging bytes, then enforce absolute read/write deadlines while handling WouldBlock and Interrupted. This preserves bounded requests without changing socket options after peer shutdown.
Validation: protocol/CLI tests and Clippy pass, including immediate peer shutdown, delayed request bodies and stalled headers. The isolated native Windows app + CLI integration test passes. The full platform matrix will validate macOS/Linux before the unpublished 0.10.0 release proceeds.