Repository navigation
Add lighting schedules, application rules, cues and focus timers - #58
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0efcde086
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.restore_routine()?; | ||
| self.routines.configure(config)?; |
There was a problem hiding this comment.
When the user saves while an application rule is active, this restores the underlying scene before Runtime::configure attempts to write the new configuration. If that write fails—for example because the disk is full or the configuration directory becomes unwritable—the save reports an error even though lighting has already changed; moreover, the old foreground value remains while the restoration state is cleared, so the previous rule will not be reapplied until focus changes. Save successfully before restoring, or explicitly roll back/re-evaluate the rule on failure.
Useful? React with 👍 / 👎.
Adds a local routines editor in Scenes: recurring weekday schedules with immediate/fade transitions, explicitly selected application rules, temporary cues and focus/break timers. Manual lighting changes cancel pending app restoration and fades; cues preserve the underlying scene and honor Stop, quiet hours and comfort limits. Schedules deduplicate local dates and skip missed/startup/wake/timezone-change boundaries.
Adds authenticated API v1/CLI routine controls and bumps desktop/CLI to 0.13.0 for automatic release. Routines use offline profile snapshots; capture starts remain explicit. App matching uses local OS application names, with X11 support and an explicit Wayland unavailable status.
docs/routines.mddescribes timing, precedence, restoration and supported scope.Validation: 81 native unit tests pass (one separate interactive capture test remains excluded from the ordinary suite), strict desktop/control Clippy, 9 control tests, 14 release tests, browser controls and isolated Windows native timer/off-state smoke. No physical USB or capture was started by the routine smoke. Physical Mac/X11, strip fades and assistive technology validation remain in #37, #38 and #45.
Closes #10
Closes #15
Closes #25
Closes #9