Repository navigation
Fix browser video lighting with window area selection - #63
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a video plays inside a browser page, whole-window edge sampling follows the white page margins and toolbars instead of the video. Add an optional area within a selected window, with an explicit in-memory still preview and drag/percentage selection, so users can sample the video itself. Window capture follows the visible tab; the UI explains when to reselect after layout changes.
The crop stays local, scales with the window, preserves physical LED routing, and applies before black-bar detection. Changing it requires Start / Retry. Windows preview and lighting share the same capture backend and exclude texture pixels outside ContentSize. Existing source settings remain compatible. Prepare release 0.16.2 and update the capture guide and release notes.
Validation:
Physical macOS/Linux window capture and the user's actual browser/LED combination still need hands-on validation; the platform build matrix runs on this PR.