Cache missing token properties for one minute - #1648
Open
stefangutica wants to merge 7 commits into
Open
stefangutica wants to merge 7 commits into
stefangutica wants to merge 7 commits into
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
nullwas cached like any other value. It stayed 1 hour for the token transfer properties and 1 week for the esdt properties read from the gateway.Proposed Changes
getTokenTransferPropertiesandgetEsdtTokenPropertieskeepgetOrSet, so concurrent misses still share one load and Redis hits are still kept in memory. They now passcacheNullable: false, and when the raw method returnsnullthe loader caches it for one minute itself.getTokenTransferPropertiesFromLogskeepsbatchApplyAll, now over the distinct identifiers. The batch caches the existing tokens with the standard ttl, and the missing ones are cached asnullfor one minute withsetMany.getEsdtTokenPropertiesRawFromElasticreturnsnullwhen the token is not in Elastic, like the gateway source, instead of failing in the mapping.getEsdtTokenPropertiesuses theCacheInfo.EsdtPropertiesttl (one day) instead of the hardcoded one week.How to test
npx jest src/test/unit/services/token.transfer.properties.spec.tsnullfor one minute: checkTTL token:transfer:properties:v2:<identifier>andTTL esdt:v2:<identifier>in Redis.nullfor one minute.