Skip to content

Work around GCC 12 optional parsing crash with native tuple storage #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Altren wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

Work around GCC 12 optional parsing crash with native tuple storage #752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d59f9c
Work around GCC 12 optional parsing crash with native tuple storage
Altren Oct 22, 2026
dd51f93
Remove standalone regression test from storage workaround
Altren Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions include/rfl/Tuple.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Tuple {

static constexpr unsigned int num_bytes_ = std::get<size_>(positions_);

using DataType = std::array<unsigned char, num_bytes_>;
using DataType = unsigned char[num_bytes_];

public:
/// Constructs a Tuple by copying from the provided arguments.
Expand Down Expand Up @@ -68,7 +68,7 @@ class Tuple {
template <int _index>
constexpr auto& get() {
using Type = internal::nth_element_t<_index, Types...>;
return *internal::ptr_cast<Type*>(data_.data() + pos<_index>());
return *internal::ptr_cast<Type*>(data_ + pos<_index>());
}

/// Gets an element by index (const).
Expand All @@ -77,7 +77,7 @@ class Tuple {
template <int _index>
constexpr const auto& get() const {
using Type = internal::nth_element_t<_index, Types...>;
return *internal::ptr_cast<const Type*>(data_.data() + pos<_index>());
return *internal::ptr_cast<const Type*>(data_ + pos<_index>());
}

/// Copy assignment operator. Assigns from another Tuple by copy.
Expand Down Expand Up @@ -157,7 +157,7 @@ class Tuple {
const auto copy_one = [this]<int _i>(const auto& _other,
std::integral_constant<int, _i>) {
using Type = internal::nth_element_t<_i, Types...>;
::new (static_cast<void*>(data_.data() + pos<_i>()))
::new (static_cast<void*>(data_ + pos<_i>()))
Type(_other.template get<_i>());
};
(copy_one(_other, std::integral_constant<int, _is>{}), ...);
Expand All @@ -172,7 +172,7 @@ class Tuple {
const auto copy_one = [this]<int _i>(const auto& _t,
std::integral_constant<int, _i>) {
using Type = internal::nth_element_t<_i, Types...>;
::new (static_cast<void*>(data_.data() + pos<_i>())) Type(_t);
::new (static_cast<void*>(data_ + pos<_i>())) Type(_t);
};
(copy_one(_types, std::integral_constant<int, _is>{}), ...);
}
Expand All @@ -198,7 +198,7 @@ class Tuple {
const auto move_one = [this]<int _i>(auto&& _other,
std::integral_constant<int, _i>) {
using Type = internal::nth_element_t<_i, Types...>;
::new (static_cast<void*>(data_.data() + pos<_i>()))
::new (static_cast<void*>(data_ + pos<_i>()))
Type(std::move(_other.template get<_i>()));
};
(move_one(_other, std::integral_constant<int, _is>{}), ...);
Expand All @@ -212,7 +212,7 @@ class Tuple {
const auto move_one = [this]<int _i>(auto&& _t,
std::integral_constant<int, _i>) {
using Type = internal::nth_element_t<_i, Types...>;
::new (static_cast<void*>(data_.data() + pos<_i>())) Type(std::move(_t));
::new (static_cast<void*>(data_ + pos<_i>())) Type(std::move(_t));
};
(move_one(std::move(_types), std::integral_constant<int, _is>{}), ...);
}
Expand Down
Loading