fix(phase20): fail-closed onboarding governance (W1) - #57
Merged
Merged
Conversation
…er-checker, claim-map allowlist, user suspension, dev-flag gates - GAP 1: onboarding.selectRole restricted to trader-level 'user'; privileged roles require role_requests maker-checker (reviewRoleRequest, maker!=checker, audited) - GAP 4: admin:all removed from API-key self-issuance; elevated scopes via api_scope_requests maker-checker - GAP 5: bare Keycloak claims no longer auto-map; ADMIN_ROLE_CLAIM_MAP allowlist; audited auto-provision; unknown privileged claims -> lowest privilege + pending role request - GAP 9: users.status (active/suspended/offboarded) + admin suspend/reactivate/offboard + auth enforcement - GAP 6: NIGERIA_ID_ALLOW_UNSIGNED_DEV_TOKENS gate, production boot refusal; kyc mock fallback confirmed removed - migration 0073 + journal; 20 new tests; tsc clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 20 W1 — stakeholder-onboarding audit gaps 1,4,5,6(partial),9 for singlewindow. See commit message; tests 20/20 + tsc clean.