Clear the barline drag offset on release - #34820
Conversation
endDragGrip adds the drag offset into the layout data in order to work out which staff the barline now ends on, but never takes it back out, so y2 goes on describing the dragged position rather than the one about to be laid out. y1 is offset there too, though nothing in the function reads it. The barline therefore keeps drawing at the dragged length until something forces a layout, which is why one dragged less than half of the way towards the staff below carries on drawing a partial segment between the staves while it stays selected, and only snaps into place on deselecting it. Read the offset from the edit data instead and leave the layout data alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough
Merge Risk: ⚪ Minimal · up to Releasing a dragged barline now snaps its span using the final transient grip position without retaining a partial rendered segment. The focused change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves: #34819
AI generated fix; please review critically.
Barlines now snap to their expected position when the grab handle is released, avoiding partial segments continuing to draw while the barline remains selected.
Screen.Recording.2026-09-05.at.10.57.09.mov