Skip to content

Address review comments across run.sh, init.py, run.py, and tests - #89

Merged
mvfc merged 4 commits into
mc/organization_exportfrom
fix-review-comments-2794077306971618080
Oct 26, 2026
Merged

mvfc merged 4 commits into
mc/organization_exportfrom
fix-review-comments-2794077306971618080

Conversation

@mvfc

@mvfc mvfc commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Updated backup completion verification in run.sh and src/run.py using an explicit .complete marker file; validated org_export_mode and BACKUP_ENCRYPTION_MODE in src/init.py returning HTTP 400 when single export mode is used with non-raw encryption; documented export permissions in README.md and src/form.html; updated tests/docker_test.sh checks; and adjusted heading levels in tests/README.md.


PR created automatically by Jules for task 2794077306971618080 started by @mvfc

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge; both numbered findings are fixed and no new blocking issues were found.

Summary

This PR adds an explicit backup completion marker, rejects unsupported export settings before creating the database, and updates documentation and tests.

Since the previous review:

  • Startup skips a backup only when a completion marker and an encrypted backup file exist.
  • Setup rejects single organization exports unless raw encryption is selected.
  • Test helpers recognize more warning output and check container tools directly.

Checks were based on code inspection; no tests were run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Start[Container starts] --> Check{Completion marker and encrypted files exist?}
    Check -->|Yes| Schedule[Start scheduler]
    Check -->|No| Backup[Run initial backup]
    Backup --> Schedule
    Success[Backup succeeds] --> Marker[Write completion marker]
    Cleanup[Remove expired backups] --> Remaining{Encrypted files remain?}
    Remaining -->|No| Remove[Remove completion marker]
    Remaining -->|Yes| Keep[Keep completion marker]
Loading

Reviews (4) · Last reviewed commit: "fix: resolve review comments for cleanup..." · Reviewed by Greptile

…tests

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 55502c50-a1b6-4d5b-acc1-dd91cedcd5db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread src/init.py
Comment thread run.sh Outdated
…d tests

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Comment thread cleanup.sh Outdated
…backup markers

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Comment thread tests/test_e2e.py Outdated
…dation, and tests

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@mvfc
mvfc merged commit 6a7a8d3 into mc/organization_export Oct 26, 2026
3 checks passed
@mvfc
mvfc deleted the fix-review-comments-2794077306971618080 branch October 26, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant