Repository navigation
Address review comments across run.sh, init.py, run.py, and tests - #89
Conversation
…tests Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
…d tests Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…backup markers Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…dation, and tests Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Updated backup completion verification in run.sh and src/run.py using an explicit .complete marker file; validated org_export_mode and BACKUP_ENCRYPTION_MODE in src/init.py returning HTTP 400 when single export mode is used with non-raw encryption; documented export permissions in README.md and src/form.html; updated tests/docker_test.sh checks; and adjusted heading levels in tests/README.md.
PR created automatically by Jules for task 2794077306971618080 started by @mvfc


Confidence Score: 5/5
This PR appears safe to merge; both numbered findings are fixed and no new blocking issues were found.Summary
This PR adds an explicit backup completion marker, rejects unsupported export settings before creating the database, and updates documentation and tests.
Since the previous review:
Checks were based on code inspection; no tests were run.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD Start[Container starts] --> Check{Completion marker and encrypted files exist?} Check -->|Yes| Schedule[Start scheduler] Check -->|No| Backup[Run initial backup] Backup --> Schedule Success[Backup succeeds] --> Marker[Write completion marker] Cleanup[Remove expired backups] --> Remaining{Encrypted files remain?} Remaining -->|No| Remove[Remove completion marker] Remaining -->|Yes| Keep[Keep completion marker]Reviews (4) · Last reviewed commit: "fix: resolve review comments for cleanup..." · Reviewed by Greptile