Repository navigation
Update initial backup skip logic to rely solely on complete success marker - #91
Conversation
Require the explicit success marker file (.complete) to skip the initial backup, ensuring partial or failed backup runs without a marker file are retried on container start. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Require the explicit success marker file (.complete) to skip the initial backup, ensuring partial or failed backup runs without a marker file are retried on container start. Direct script execution tests added. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh. Update test suite to execute run.sh directly and handle missing ADMIN_TOKEN secret gracefully in E2E workflow. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh. Update test suite to execute run.sh directly and handle missing ADMIN_TOKEN secret gracefully in E2E workflow. Fix JSON parsing for Bitwarden CLI. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh. Update test suite to execute run.sh directly, unlock vault in E2E session fixture, and handle missing ADMIN_TOKEN secret gracefully in E2E workflow. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh. Update test suite to execute run.sh directly, unlock vault in E2E session fixture, and set default ADMIN_TOKEN in E2E workflow. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh. Update test suite to execute run.sh directly with explicit DB_PATH and timeouts, and enforce fatal exit for missing ADMIN_TOKEN on release runs. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Updated
run.shinitial-backup skip logic so.encfiles are not treated as proof of completion. The script now relies solely on the explicit.completesuccess marker file written upon successful backup execution, ensuring any failures or partial backups are retried on container start. Unit tests covering both skip and run conditions were added totests/test_run.py.PR created automatically by Jules for task 6331194696084643102 started by @mvfc


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues were found.Summary
run.shuses only.completeto decide whether to skip the initial backup..completeexists.Reviews (7) · Last reviewed commit: "Update e2e.yml" · Reviewed by Greptile