Skip to content

Update initial backup skip logic to rely solely on complete success marker - #91

Merged
mvfc merged 9 commits into
mc/organization_exportfrom
fix-initial-backup-skip-logic-6331194696084643102
Oct 26, 2026
Merged

mvfc merged 9 commits into
mc/organization_exportfrom
fix-initial-backup-skip-logic-6331194696084643102

Conversation

@mvfc

@mvfc mvfc commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Updated run.sh initial-backup skip logic so .enc files are not treated as proof of completion. The script now relies solely on the explicit .complete success marker file written upon successful backup execution, ensuring any failures or partial backups are retried on container start. Unit tests covering both skip and run conditions were added to tests/test_run.py.


PR created automatically by Jules for task 6331194696084643102 started by @mvfc

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no blocking issues were found.

Summary

run.sh uses only .complete to decide whether to skip the initial backup.

  • Container startup skips the first backup when .complete exists.
  • The E2E workflow runs for startup and cleanup script changes.

Reviews (7) · Last reviewed commit: "Update e2e.yml" · Reviewed by Greptile

Require the explicit success marker file (.complete) to skip the initial
backup, ensuring partial or failed backup runs without a marker file
are retried on container start.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d361891a-f613-43fd-8a41-95e4d0d86abb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread tests/test_run.py Outdated
Require the explicit success marker file (.complete) to skip the initial
backup, ensuring partial or failed backup runs without a marker file
are retried on container start. Direct script execution tests added.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Comment thread tests/test_run.py
Require explicit success marker (.complete) to skip initial backup in run.sh.
Update test suite to execute run.sh directly and handle missing ADMIN_TOKEN
secret gracefully in E2E workflow.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Comment thread .github/workflows/e2e.yml Outdated
Require explicit success marker (.complete) to skip initial backup in run.sh.
Update test suite to execute run.sh directly and handle missing ADMIN_TOKEN
secret gracefully in E2E workflow. Fix JSON parsing for Bitwarden CLI.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Comment thread src/bw_client.py Outdated
mvfc and others added 5 commits October 26, 2026 14:17
Require explicit success marker (.complete) to skip initial backup in run.sh.
Update test suite to execute run.sh directly, unlock vault in E2E session
fixture, and handle missing ADMIN_TOKEN secret gracefully in E2E workflow.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh.
Update test suite to execute run.sh directly, unlock vault in E2E session
fixture, and set default ADMIN_TOKEN in E2E workflow.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Require explicit success marker (.complete) to skip initial backup in run.sh.
Update test suite to execute run.sh directly with explicit DB_PATH and timeouts,
and enforce fatal exit for missing ADMIN_TOKEN on release runs.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@mvfc
mvfc merged commit 623b563 into mc/organization_export Oct 26, 2026
3 checks passed
@mvfc
mvfc deleted the fix-initial-backup-skip-logic-6331194696084643102 branch October 26, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant