Skip to content

Remove stale .complete marker in run.sh when no backups exist - #92

Merged
mvfc merged 5 commits into
mc/organization_exportfrom
fix-empty-backup-folder-skip-5606918260970887226
Oct 27, 2026
Merged

mvfc merged 5 commits into
mc/organization_exportfrom
fix-empty-backup-folder-skip-5606918260970887226

Conversation

@mvfc

@mvfc mvfc commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

This change updates run.sh to check for .enc backup files when .complete marker is present. If no .enc backup files exist in the backup directory, run.sh removes the stale .complete marker and runs the initial backup. Unit tests in tests/test_run.py were updated and added to cover this scenario.


PR created automatically by Jules for task 5606918260970887226 started by @mvfc

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no new actionable issues remain.

Summary

run.sh removes a stale .complete marker when no .enc backups remain, then attempts an initial backup.

  • Backvault startup checks for encrypted backups before trusting its completion marker.
  • Pull-request E2E runs skip when ADMIN_TOKEN is unavailable.
  • The E2E fixture logs in and then unlocks the test account.

Reviews (5) · Last reviewed commit: "Remove stale .complete marker in run.sh ..." · Reviewed by Greptile

If an operator moves or deletes .enc backup files while leaving .complete,
restarting the container skipped initial backup. This checks for .enc files
and removes stale .complete markers before deciding whether to skip initial backup.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d492d7e4-9eac-4a7a-bd4d-8b7a4fe76584

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread run.sh Outdated
mvfc and others added 3 commits October 26, 2026 16:32
If an operator moves or deletes .enc backup files while leaving .complete,
restarting the container skipped initial backup. This checks for .enc files
and removes stale .complete markers safely without stopping container startup
if removal fails.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
If an operator moves or deletes .enc backup files while leaving .complete,
restarting the container skipped initial backup. This checks for .enc files
and removes stale .complete markers safely without stopping container startup
if removal fails. Also ensures E2E test session unlocks vault after login.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
If an operator moves or deletes .enc backup files while leaving .complete,
restarting the container skipped initial backup. This checks for .enc files
and removes stale .complete markers safely without stopping container startup
if removal fails. Also ensures E2E test session unlocks vault after login.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Comment thread .github/workflows/e2e.yml Outdated
If an operator moves or deletes .enc backup files while leaving .complete,
restarting the container skipped initial backup. This checks for .enc files
and removes stale .complete markers safely without stopping container startup
if removal fails. Also ensures E2E test session unlocks vault after login and
only skips E2E workflow when ADMIN_TOKEN is missing on pull requests.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@mvfc
mvfc merged commit f847ffa into mc/organization_export Oct 27, 2026
3 checks passed
@mvfc
mvfc deleted the fix-empty-backup-folder-skip-5606918260970887226 branch October 27, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant